Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve invsee gui & add support for some modded inventories #185

Merged
merged 10 commits into from
Feb 8, 2025

Conversation

Lyfts
Copy link
Member

@Lyfts Lyfts commented Feb 3, 2025

This aims to make invsee (or /inv view) feel more a lot more polished and replaces the old barebones ui completely.

Also adds support for a few modded inventories and currently supports the following inventories:
Main & Ender chest,
Battlegear,
Baubles (Extended),
Galacticraft,
Adventure Backpacks (only "worn" backpacks, can't update live),
MC Backpacks (only "personal" backpack, can't update live),
Tinkers knapsack & accessories.

All of these work for both online & offline players.
Note that if you use /inv view on yourself the player inventory will not live-update, but it does update correctly when used on other players.

su_invsee

Closes #184

@Lyfts Lyfts requested a review from a team February 3, 2025 16:46
@boubou19
Copy link
Member

boubou19 commented Feb 3, 2025

it's missing galacticraft inventory, but that will do it for now

@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Feb 3, 2025
@boubou19
Copy link
Member

boubou19 commented Feb 4, 2025

If i shift click my cutter on the screen, i crash clientside
image
crash-2025-02-04_11.43.34-client.txt

If i move the item normally, it works well.

Testing this PR through 2.1.20-pre

@Lyfts
Copy link
Member Author

Lyfts commented Feb 4, 2025

wwwwwwwwwwwwwwwwwwwwwwwwwww

Alright GC's inv is also supported now

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Warning: 2 uncommitted changes
pull request create failed: GraphQL: Head sha can't be blank, Base sha can't be blank, Head repository can't be blank, No commits between GTNewHorizons:invsee-improvements and origin:GTNewHorizons-invsee-improvements-spotless-fixes, Head ref must be a branch, not all refs are readable (createPullRequest)

Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functionality looks great! Bonus points for adding backhand support to the main tab in a follow-up PR 😉

@serenibyss serenibyss merged commit 966e776 into master Feb 8, 2025
1 check passed
@serenibyss serenibyss deleted the invsee-improvements branch February 8, 2025 18:27
@serenibyss serenibyss removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/inv view command has issues
4 participants